Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.96%. Comparing base (5a96926) to head (0bfc634).

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   54.96%   54.96%   -0.01%     
==========================================
  Files         481      481              
  Lines       67391    67390       -1     
==========================================
- Hits        37043    37040       -3     
  Misses      27329    27329              
- Partials     3019     3021       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks @omarsy 🎉. This looks like the right place for the fix. Is it necessary to declare the new bzl slice or could this be solved by referencing field's type directly?

Thank you for your review @deelawn
Something like that ?

bz = append(bz, '{')
for i := 0; i < sl; i++ {
	fv := fillValueTV(store, &sv.Fields[i])
	omitTypes := FieldTypeList(bt.Fields).Types()[i].Kind() != InterfaceKind
	bz = append(bz, fv.ComputeMapKey(store, omitTypes)...)
	if i != sl-1 {
		bz = append(bz, ',')
	}
}

I use a variable for optimisation stuff, .Types() have a loop

Thanks @omarsy 🎉. This looks like the right place for the fix. Is it necessary to declare the new bzl slice or could this be solved by referencing field's type directly?

Thank you for your review @deelawn Something like that ?

bz = append(bz, '{')
for i := 0; i < sl; i++ {
	fv := fillValueTV(store, &sv.Fields[i])
	omitTypes := FieldTypeList(bt.Fields).Types()[i].Kind() != InterfaceKind
	bz = append(bz, fv.ComputeMapKey(store, omitTypes)...)
	if i != sl-1 {
		bz = append(bz, ',')
	}
}

I use a variable for optimisation stuff, .Types() have a loop

Would it be the same as using omitTypes := bt.Fields[i].Type.Kind() != InterfaceKind? If so, then no need to allocate a new slice for this operation.

Thanks @omarsy 🎉. This looks like the right place for the fix. Is it necessary to declare the new bzl slice or could this be solved by referencing field's type directly?

Thank you for your review @deelawn Something like that ?

bz = append(bz, '{')
for i := 0; i < sl; i++ {
	fv := fillValueTV(store, &sv.Fields[i])
	omitTypes := FieldTypeList(bt.Fields).Types()[i].Kind() != InterfaceKind
	bz = append(bz, fv.ComputeMapKey(store, omitTypes)...)
	if i != sl-1 {
		bz = append(bz, ',')
	}
}

I use a variable for optimisation stuff, .Types() have a loop

Would it be the same as using omitTypes := bt.Fields[i].Type.Kind() != InterfaceKind? If so, then no need to allocate a new slice for this operation.

My mistake, it's actually the same, no need for a new variable. Your suggestion is better.
Completed here: 0323970